Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Make Reports-related Dashboard main tab initially ...

tnisan at redhat.com tnisan at redhat.com
Sun Aug 28 08:07:32 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Make Reports-related Dashboard main tab initially hidden
......................................................................


webadmin: Make Reports-related Dashboard main tab initially hidden

In 4.0, even though we don't ship Reports anymore, UI still contains
code for Reports integration: (Reports related) "Dashboard" main tab
will be shown on the right-hand side of tab panel for a brief moment,
until the UI detects unavailability of Reports & hiding that tab.

This is unrelated to the "Dashboard" main tab shown on the left-hand
side of tab panel, representing the oVirt Dashboard feature introduced
in 4.0.

This patch simply sets the (Reports related) "Dashboard" main tab to
be initially hidden, which fixes the above mentioned UX issue. Due to
Reports not available in 4.0, that tab will never become visible.

Change-Id: I155ac581eb71febb55df84b339a6ab46b729dde7
Bug-Url: https://bugzilla.redhat.com/1365980
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/62219
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I155ac581eb71febb55df84b339a6ab46b729dde7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list