Change in ovirt-engine[master]: core: Avoid using static for config value.

mlipchuk at redhat.com mlipchuk at redhat.com
Tue Aug 30 09:09:57 UTC 2016


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Avoid using static for config value.
......................................................................


core: Avoid using static for config value.

There is not reason to use static value for config value since this
value is already cached from the DB.

Change-Id: Ideb5d770cf836dd4a4e6519c6aac7db0f13e23f9
Bug-Url: https://bugzilla.redhat.com/1348405
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java
4 files changed, 1 insertion(+), 28 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Looks good to me, approved
  Yanir Quinn: Verified



-- 
To view, visit https://gerrit.ovirt.org/62946
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ideb5d770cf836dd4a4e6519c6aac7db0f13e23f9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list