Change in ovirt-engine[master]: core: HttpImageTaskVDSCommand - problematic type inference

laravot at redhat.com laravot at redhat.com
Wed Aug 31 09:17:07 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: HttpImageTaskVDSCommand - problematic type inference
......................................................................


core: HttpImageTaskVDSCommand - problematic type inference

In change Iaed648bcf979d682389a4df92, the explicit Integer type was
removed from the call to Config.getValue(), that causes the type to
be infered as Long and fails on ClassCastException.

When the type is explictly specified, the returned value is an Integer
which is outboxed and can be passed to future.get().

Change-Id: I349a08a7d119bcc57f8f6a88331c9ea64790cc99
Bug-Url: https://bugzilla.redhat.com/1371833
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/63053
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I349a08a7d119bcc57f8f6a88331c9ea64790cc99
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list