Change in ovirt-engine[master]: webadmin: DirectoryX fix

Code Review gerrit at ovirt.org
Fri Dec 2 13:04:36 UTC 2016


>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: DirectoryX fix
......................................................................


webadmin: DirectoryX fix

- The custom serializers for DirectoryGroup and DirectoryUser where causing
  the deserialization of the user/group objects to fail with the new GWT-RPC
  mechanism. Since they didn't appear to add any value I removed the custom
  serializers and implemented a default constructor so the application can
  instantiate the objects when using the standard deserialization techniques.

Change-Id: I5186a9cae7b7b7013ef531c02126afbcbceea46a
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryEntry.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser.java
D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/aaa/DirectoryGroup_CustomFieldSerializer.java
D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser_CustomFieldSerializer.java
5 files changed, 15 insertions(+), 80 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Ravi Nori: Verified; Looks good to me, but someone else must approve
  Alexander Wels: Verified
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/67711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5186a9cae7b7b7013ef531c02126afbcbceea46a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list