Change in ovirt-engine[master]: engine: reorder elements in sysprep XML templates

Code Review gerrit at ovirt.org
Thu Dec 8 11:36:19 UTC 2016


>From Tomas Jelinek <tjelinek at redhat.com>:

Tomas Jelinek has submitted this change and it was merged.

Change subject: engine: reorder elements in sysprep XML templates
......................................................................


engine: reorder elements in sysprep XML templates

The order of elements is arbitrary to some degree. The commit reorders
the elements so that the order is same between 32-bit and 64-bit version
of the XML. This leads to nicer diffs and makes it easier to spot
errors.

In the process some useless comments were removed. Apart from this the
commit does not introduce any changes to the elements themselves.

Change-Id: Ide66a00cc64a653828a8ca4d376e139811aa6574
Signed-off-by: Tomáš Golembiovský <tgolembi at redhat.com>
---
M packaging/conf/sysprep/sysprep.2k8x64
M packaging/conf/sysprep/sysprep.w10x64
M packaging/conf/sysprep/sysprep.w7x64
M packaging/conf/sysprep/sysprep.w8x64
4 files changed, 107 insertions(+), 126 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Shahar Havivi: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Michal Skrivanek: Looks good to me, but someone else must approve
  Tomas Golembiovsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/67948
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide66a00cc64a653828a8ca4d376e139811aa6574
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list