Change in ovirt-engine[master]: webadmin: Improve IE image size quirk workaround performance

Code Review gerrit at ovirt.org
Tue Dec 13 14:17:40 UTC 2016


>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin: Improve IE image size quirk workaround performance
......................................................................


webadmin: Improve IE image size quirk workaround performance

DOM mutation events like `DOMNodeInserted` are deprecated, not supported
consistently across different browsers, and usually very slow as well:

https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Mutation_events

This patch modifies IE image size quirk workaround to use insertionQuery
library (IE10+ compatible) to improve performance:

https://github.com/naugtur/insertionQuery

Change-Id: Ic371c5b094db90467292d9d10adfbfafee3eff72
Bug-Url: https://bugzilla.redhat.com/1378935
Related-To: https://bugzilla.redhat.com/1255428
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BrowserHacks.java
A packaging/branding/ovirt.brand/insQ-1.0.3.min.js
3 files changed, 16 insertions(+), 9 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/64294
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic371c5b094db90467292d9d10adfbfafee3eff72
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list