Change in ovirt-engine[master]: core: StorageJob - adding support to inspect the job error code

Code Review gerrit at ovirt.org
Tue Dec 13 16:04:04 UTC 2016


>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: core: StorageJob - adding support to inspect the job error code
......................................................................


core: StorageJob - adding support to inspect the job error code

When a storage job fails with some error we may want to perform some
operations or to consider the execution as succesful.
For example - if a deletion fails because the storage object doesn't
exist the engine may want to consider the operation as succesful.

This patch adds support to handle the error code of failed jobs and to
return a different status if needed.

Change-Id: Ifad25682f29e0fcda532aa0f41cb2a50e02cfb73
Bug-Url: http://bugzilla.redhat.com/1403839
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageJobCommand.java
2 files changed, 33 insertions(+), 0 deletions(-)

Approvals:
  Liron Aravot: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/67896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifad25682f29e0fcda532aa0f41cb2a50e02cfb73
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list