Change in ovirt-engine[master]: webadmin: new networkprofile dialog sets badly migratable ch...

Code Review gerrit at ovirt.org
Wed Dec 14 07:50:28 UTC 2016


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: webadmin: new networkprofile dialog sets badly migratable checkbox
......................................................................


webadmin: new networkprofile dialog sets badly migratable checkbox

when passthrough is false, migratable must be true and it must not be
possible to untick this checkbox. Therefore setting migratable and
passthrough values must be done only after event listeners are set up.

Change-Id: I38924efc0aeb8caf7a130f6bf63fce0505f4bbc0
Bug-Url: https://bugzilla.redhat.com/1402703
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/68352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38924efc0aeb8caf7a130f6bf63fce0505f4bbc0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list