Change in ovirt-engine[master]: core: adding HostJobInfo/VDSError toString()

Code Review gerrit at ovirt.org
Wed Dec 14 13:03:48 UTC 2016


>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: core: adding HostJobInfo/VDSError toString()
......................................................................


core: adding HostJobInfo/VDSError toString()

This change adds the toString() to the HostJobInfo/VDSError classes.
HostJobInfo represents the current status of a job executed by vdsm -
returned when executing the GetHostJobsVDSCommand. The results of the
execution are logged - adding toString() will make it readable.
HostJobInfo has VDSError member, therefore a toString() is being added
to it as well.

before:
FINISH, GetHostJobsVDSCommand, return:
{a4c19e06-df55-4ca0-9d7e-3a12fcf59929=
org.ovirt.engine.core.common.businessentities.HostJobInfo at 3657bbdd}

after:
FINISH, GetHostJobsVDSCommand, return:
{fcd3813b-6783-442e-8659-ab6b2b11879b=
HostJobInfo:{id='fcd3813b-6783-442e-8659-ab6b2b11879b',
type='storage', description='move_device', status='failed',
progress='null', error='VDSError:{code='UnsupportedOperationErr',
message='Operation not supported'}'}}

Change-Id: I75c1033f573bec4719a8f40f7f0408217c4fbab6
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostJobInfo.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VDSError.java
2 files changed, 22 insertions(+), 0 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/68405
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75c1033f573bec4719a8f40f7f0408217c4fbab6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list