Change in ovirt-engine[master]: webadmin: add error indication to invalid VM name

Code Review gerrit at ovirt.org
Thu Dec 22 12:05:41 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: add error indication to invalid VM name
......................................................................


webadmin: add error indication to invalid VM name

When importing a VM there was no indication of an invalid
VM name in the general sub tab, this patch adds a
highlight with the information in the tooltip by changing
the UI element to StringEntityModelTextBoxOnlyEditor
which has validation unlike the previous TextBoxChanger.

Change-Id: Ia6484840460ea05f8e186f410b89c58b39d0d79d
Bug-Url: https://bugzilla.redhat.com/1403578
Signed-off-by: Benny Zlotnik <bzlotnik at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
2 files changed, 14 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Benny Zlotnik: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/68452
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6484840460ea05f8e186f410b89c58b39d0d79d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list