Change in ovirt-engine[ovirt-engine-4.0]: core: DeactivateStorageDomainWithOvfUpdate - context passing

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: DeactivateStorageDomainWithOvfUpdate - context passing
......................................................................


core: DeactivateStorageDomainWithOvfUpdate - context passing

Currently DeactivateStorageDomainWithOvfUpdate passes its compensation
context to the executed DeactivateStorageDomain command.

When passing the compensation context along the hirerchy, it was decided
in BZ 1364804 that the reponsiblity to revert the compensation data is on
the parent command.

DeactivateStorageDomainWithOvfUpdate is always succesfull (so is its
end methods) - and therefore in case of error in the child command
execution the compensation context isn't reverted which causes the domain
to remain locked.
This patch solves that by not passing the context to the executed
command - so it will have a compensation context of its own.

Change-Id: Iebbb3084d52c7744d1f92a98c31d3a3c916e6e03
Bug-Url: https://bugzilla.redhat.com/1405772
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/68965
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iebbb3084d52c7744d1f92a98c31d3a3c916e6e03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>