Change in ovirt-engine[ovirt-engine-4.0]: core: USB controller in osinfo

Code Review gerrit at ovirt.org
Sun Dec 25 12:11:12 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: USB controller in osinfo
......................................................................


core: USB controller in osinfo

This patch introduces new osinfo option "devices.usb.controller". It
will allow to configure VM USB controller per operating system and
cluster version when SPICE USB redirection is disabled (VM > Console >
USB Support in Webadmin).  This settings will not effect used USB
controllers when SPICE USB redirection is enabled.

Before this patchset engine didn't create any USB controller when SPICE
USB redirection was disabled and thus no USB controller device was
present in domain XML passed from VDSM to libvirt. Libvirt automatically
adds defautl USB controller if domain xml doesn't specify otherwise.

Motivation for this patchset is to
* allow users to optionally use controllers compatible with new USB
  specifications (USB 3.1)
* some controllers seems not to be compatible with ppc

Change-Id: Idfaf61f0695a4462adc35a5d3b24b8a4f652d5b8
Bug-Url: https://bugzilla.redhat.com/1373223
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UsbControllerModel.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
5 files changed, 80 insertions(+), 1 deletion(-)

Approvals:
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/68667
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idfaf61f0695a4462adc35a5d3b24b8a4f652d5b8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list