Change in ovirt-engine[master]: core: MultipleStorageDomainsValidatorTest#spId

Code Review gerrit at ovirt.org
Wed Dec 28 07:25:03 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: MultipleStorageDomainsValidatorTest#spId
......................................................................


core: MultipleStorageDomainsValidatorTest#spId

The spId is only used in the setUp() method, so there's no reason to
keep it as a member.
This patch converts it to a local variable.

Change-Id: Ifd5886ee24da9754db8eebe0b46a37651c7aa3a3
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidatorTest.java
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/69207
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd5886ee24da9754db8eebe0b46a37651c7aa3a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list