Change in ovirt-engine[ovirt-engine-4.1]: engine: set a valid singleQxlPci value for v2v VMs

Code Review gerrit at ovirt.org
Wed Dec 28 12:21:43 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: engine: set a valid singleQxlPci value for v2v VMs
......................................................................


engine: set a valid singleQxlPci value for v2v VMs

In case of v2v from KVM, the singleQxlPci value of the imported VM was
always set to 'true' without any validation (since it isn't read from
OVF in case of KVM, it was set to a default value).
The singleQxlPci is supported only when the VM's OS is Linux
and the Video device type is QXL and only on those cases it should be
set to 'true'.

Since the singleQxlPci validation is done in updateVm command, in case
of a none Linux VM or if video type is not QXL, each update operation
via the APIs failed in validation phase.

This is the exact senario occured in BZ 1408715.

Change-Id: I7c01d632652e5982cf7d87da8f64e57ebbc6f603
Bug-Url: https://bugzilla.redhat.com/1408715
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified



-- 
To view, visit https://gerrit.ovirt.org/69174
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c01d632652e5982cf7d87da8f64e57ebbc6f603
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list