Change in ovirt-engine[ovirt-engine-4.1]: core: remove unneeded query when getting vms to move to unknown

Code Review gerrit at ovirt.org
Thu Dec 29 09:40:48 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: remove unneeded query when getting vms to move to unknown
......................................................................


core: remove unneeded query when getting vms to move to unknown

When host monitoring gets a network exception during monitoring of a
specific host, it switches this host to maintenance and moves all the
VMs running on this host to Unknown.

The retrieval of VMs that need to be switched to unknown was composed
of two parts:
1. get all the VMs running on the host (their run_on_vds points to
that host).
2. get all the VMs that migrate to the host (their migrating_to_vds
points to that host) and also are in MigratingTo status.

But (2) is redundant since at this phase of the migration run_on_vds
must point to the destination host. Therefore, this part is removed.

Note: the query for VM dynamics from the database was moved as a
preparation for future changes.

Change-Id: I1727da9d56cf3b21464da913942f115abeb1bd5b
Bug-Url: https://bugzilla.redhat.com/1317429
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
1 file changed, 7 insertions(+), 16 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/69251
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1727da9d56cf3b21464da913942f115abeb1bd5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list