Change in ovirt-engine[master]: backend: remove redundant test testInternalAnnotationCtors

masayag at redhat.com masayag at redhat.com
Mon Feb 1 11:22:49 UTC 2016


Moti Asayag has submitted this change and it was merged.

Change subject: backend: remove redundant test testInternalAnnotationCtors
......................................................................


backend: remove redundant test testInternalAnnotationCtors

CommandCtorsTest.testInternalAnnotationCtors verifies that all the
commands that are annotated with @InternalCommandAttribute contain a
constructor which its last argument is CommandContext (only those who
are listed in VdcActionType, i.e, not abstract command classes).

Since testCommandMandatoryConstructorsExistence verifies that all these
commands contain the mandatory constructor (a constructor that
receives parameters and context objects), it also covers the validation
of testInternalAnnotationCtors.

Change-Id: Iab7899fb5d18c9ca79e2276734e371885a41f86d
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandCtorsTest.java
1 file changed, 0 insertions(+), 22 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/52903
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab7899fb5d18c9ca79e2276734e371885a41f86d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list