Change in ovirt-engine[master]: core: StorageDomainDaoTest literals

amureini at redhat.com amureini at redhat.com
Mon Feb 1 17:15:06 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: StorageDomainDaoTest literals
......................................................................


core: StorageDomainDaoTest literals

Use constants from the FixturesTool class to improve the code's
readability and maintainability.

Note this patch should also have a [very slight] performance
improvement, as it uses a pre-created Guids instead of invoking the
constructor several times.

Change-Id: I476ccdf32b96e15344f000c1216651ca5d3bf313
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java
1 file changed, 34 insertions(+), 41 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Eli Mesika: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/52908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I476ccdf32b96e15344f000c1216651ca5d3bf313
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list