Change in ovirt-engine[master]: restapi: Improve multiple version support

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Feb 2 11:31:57 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Improve multiple version support
......................................................................


restapi: Improve multiple version support

This patch adds a new HTTP filter that is responsible for extracting the
version information from the request, and adding it to the object that
handles the information about the current request. This used to be part
of the "current" filter, but it is better to separate the two concerns.
The new filter supports extracting the version from the HTTP "Version"
request header:

  GET /api/...
  Version: 4

Or from an optional prefix of the request URL:

  GET /api/v4/...

Later patches will use this version information to dispatch requests to
different versions of the API.

Change-Id: I32881539b7489f51109b03e34b4713263221b288
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/Current.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/CurrentFilter.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/VersionFilter.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/VersionSource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
6 files changed, 304 insertions(+), 26 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/52688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I32881539b7489f51109b03e34b4713263221b288
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list