Change in ovirt-engine[master]: core: cleanup in vm events refresher

ahadas at redhat.com ahadas at redhat.com
Tue Feb 2 12:32:44 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: cleanup in vm events refresher
......................................................................


core: cleanup in vm events refresher

1. Inject DbFacade
2. Change 'convertEvent' to return the list of VMs
   instead of getting a list and fill it
3. Calculate fetch-time only once for both vms and devices
4. Simplify the 'convertEvent' method

Change-Id: I1e24580ea017dd5a19b668c55d78c85f4950df24
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVmStatsRefresher.java
1 file changed, 27 insertions(+), 31 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Arik Hadas: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51058
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e24580ea017dd5a19b668c55d78c85f4950df24
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list