Change in ovirt-engine[master]: core: GetAllDiskSnapshotsByStorageDomainIdQueryTest streaming

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetAllDiskSnapshotsByStorageDomainIdQueryTest streaming
......................................................................


core: GetAllDiskSnapshotsByStorageDomainIdQueryTest streaming

Replace the outdated of Apache Commons Collections' Predicate with
modern Java 8 streaming APIs to improve the code's readability and make
it more standard.

Note that this patch also offers a slight theoretical performance
improvement in case the test fails, as noneMatch returns early on the
first match, while filtering using Collections.select has to iterate the
entire list, regardless of matches.

Change-Id: I8b2d54f6e01eab2e7cf02d5a4a785ab728de04a8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/GetAllDiskSnapshotsByStorageDomainIdQueryTest.java
1 file changed, 2 insertions(+), 9 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53024
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b2d54f6e01eab2e7cf02d5a4a785ab728de04a8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>