Change in ovirt-engine[master]: core: GetAllDiskSnapshotsByStorageDomainIdQueryTest mocks

amureini at redhat.com amureini at redhat.com
Wed Feb 3 10:54:50 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetAllDiskSnapshotsByStorageDomainIdQueryTest mocks
......................................................................


core: GetAllDiskSnapshotsByStorageDomainIdQueryTest mocks

Use the @Mock annotation instead of explicitly calling Mockito.mock.
This clears up the code a bit and makes it easier for the reader to
focus on the logic of the test.

Change-Id: I3d61348726b08b47c0c1bbce0780b5a30cadbd75
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/GetAllDiskSnapshotsByStorageDomainIdQueryTest.java
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53019
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d61348726b08b47c0c1bbce0780b5a30cadbd75
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list