Change in ovirt-engine[ovirt-engine-3.6]: core: add code setting storage pool id in DetachNetworkFromV...

tnisan at redhat.com tnisan at redhat.com
Thu Feb 4 10:50:33 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: add code setting storage pool id in DetachNetworkFromVdsInterfaceCommand
......................................................................


core: add code setting storage pool id in DetachNetworkFromVdsInterfaceCommand

DetachNetworkFromVdsInterfaceCommand does not initialize storagePoolId
property defined in CommandBase. So when method:
org.ovirt.engine.core.bll.CommandBase#getMacPool
is called, it will find:
org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase#getStoragePoolId
to be null. Which causes MacPool not be found for null-valued
datacenter.

Change-Id: I2bd3d7bcb8a6bbd667d9bbde6658a8746f195692
Bug-Url: https://bugzilla.redhat.com/1299630
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Martin Mucha: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53082
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2bd3d7bcb8a6bbd667d9bbde6658a8746f195692
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list