Change in ovirt-engine[master]: core: getGuidListFromString null treatment

amureini at redhat.com amureini at redhat.com
Mon Feb 8 10:26:06 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: getGuidListFromString null treatment
......................................................................


core: getGuidListFromString null treatment

Use Apache Commons Lang's StringUtils to split the input string in order
to avoid having to explicitly handle empty strings. Nulls are converted
to empty strings and just fed into the method.

Change-Id: I5ba8c8734688c29da0ddb1adc7616ea62c3d89de
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ba8c8734688c29da0ddb1adc7616ea62c3d89de
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list