Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Prevent NPE in StorageGeneralModel

tnisan at redhat.com tnisan at redhat.com
Sun Feb 14 08:54:27 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Prevent NPE in StorageGeneralModel
......................................................................


webadmin: Prevent NPE in StorageGeneralModel

Potential NPE discovered by coverity (CID:1201871).

The connection is checked for null, then is directly referenced
a few lines after.

Change-Id: I699ec5f85d0dbb9e449e29e9476aa5a24aeb538f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1304674
Signed-off-by: Fred Rolland <frolland at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java
1 file changed, 14 insertions(+), 11 deletions(-)

Approvals:
  Alexander Wels: Verified
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/53491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I699ec5f85d0dbb9e449e29e9476aa5a24aeb538f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list