Change in ovirt-engine[master]: core: profiles: make AddUserProfile update the key

ahadas at redhat.com ahadas at redhat.com
Mon Feb 15 07:35:12 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: profiles: make AddUserProfile update the key
......................................................................


core: profiles: make AddUserProfile update the key

To accomodate the need of REST API, we make AddUserProfileCommand
detect when the client wants just to update the SSH Public key
parameters, and we handle this case inside the command as special
case of Update, trasparently.

During the verification of this patch it was discovered that the
update command was not refreshing the SSHPublicKeyID after each change.
This is harmless for {UserPortal,Webadmin} UI, but incorrect for
the REST API.
So this patch also make sure that each succesfully update
changes the key ID.

Change-Id: Ia197bddb74186fa7c696f7e7f28e8fbe5e487e08
Bug-Url: https://bugzilla.redhat.com/1283499
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java
3 files changed, 49 insertions(+), 14 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48994
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia197bddb74186fa7c696f7e7f28e8fbe5e487e08
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list