Change in ovirt-engine[ovirt-engine-3.6]: core: RunVmCommand using callbacks

tnisan at redhat.com tnisan at redhat.com
Mon Feb 15 12:29:16 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: RunVmCommand using callbacks
......................................................................


core: RunVmCommand using callbacks

Set the commnad id and the shouldBeEndedByParent with false.

RunVmCommand is calling its only child command,
CreateAllSnapshotsFromVmCommand, form the execute command
and at the endAction phase.
Once the command is used with a callback we need to change the command
to be set with ShouldBeEndedByParent as false so the snapshot and the
disk will be unlocked.

Change-Id: I6a5889eb4ab378347baa46672afaf2edf48cd738
Bug-Url: https://bugzilla.redhat.com/1305809
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Tal Nisan: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/53513
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a5889eb4ab378347baa46672afaf2edf48cd738
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list