Change in ovirt-engine[master]: core: removed duplicates among two methods

alkaplan at redhat.com alkaplan at redhat.com
Thu Feb 18 10:49:12 UTC 2016


Alona Kaplan has submitted this change and it was merged.

Change subject: core: removed duplicates among two methods
......................................................................


core: removed duplicates among two methods

whether result should be valid or invalid can be expressed in one
variable, thus method testing if all inputs are valid is duplicate

Change-Id: I68df94b9c0bc7ba7207f6a502ae1617c9e8eec0a
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
1 file changed, 41 insertions(+), 55 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/48535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68df94b9c0bc7ba7207f6a502ae1617c9e8eec0a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list