Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Fix migration policy update for running VM

[piotr.kliczewski at gmail.com]

Piotr Kliczewski has submitted this change and it was merged.

Change subject: webadmin: Fix migration policy update for running VM
......................................................................


webadmin: Fix migration policy update for running VM

Problem description:
--------------------
When a VM is running and its migration policy is pinned,
a change of the migration policy to migrateable allows the running VM
to migrate to another host.
This behavior is a security threat, passing information from the pinned
host to the migration target. And migration could fail due to
incompatible target host.

Desired behavior:
-----------------
When a VM is running and changing migration policy from pinned to
Migrateable (manual or automatic).
  - Provide warning and UX indicator.
  - If user confirms proceed with normal update.

Implementation:
--------------
1. Replace @EditableOnVmStatusField with @EditableField to
fields {dedicatedVmForVdsList, migrationSupport} (VmBase.java). Disable
(vm restart requirement), when updating dedicated hosts field or
updating migrationSupport field.

2. Redesign VmNextRunConfiguration UI to display warnning if running VM
is unpinned. Modify VmListModel.java to append warning into
VmNextRunConfigurationModel.java . Also Modify VmNextRunConfiguration
layout and widget to display selective information (coresponding to
updated fields).

Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b
Bug-Url: https://bugzilla.redhat.com/1058384
Signed-off-by: Andrej Krejcir <akrejcir at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java
9 files changed, 166 insertions(+), 44 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Andrej Krejcir: Verified



-- 
To view, visit https://gerrit.ovirt.org/53646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>