Change in ovirt-engine[master]: core: refactoring in vms-monitoring

[ahadas at redhat.com]

Arik Hadas has submitted this change and it was merged.

Change subject: core: refactoring in vms-monitoring
......................................................................


core: refactoring in vms-monitoring

1. Rename VmsMonitoring#tryLockVmForUpdate to shouldAnalyzeVm since
   this method does more than just locking the VM in order to validate
   that the VM can be updated according to the data received.

2. Remove the misleading comment for that method. It is private mehtod
   and its name describes its responsibility so no need a new comment.

3. Move that method so that the order of the methods in VmsMonitoring
   will be more similar to the control flow.

Change-Id: Icc7c43b0ade57a775ecc3b3ab52bc84289e35de2
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
1 file changed, 28 insertions(+), 32 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/53716
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc7c43b0ade57a775ecc3b3ab52bc84289e35de2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>