Change in ovirt-hosted-engine-ha[master]: storage: fixing a double call of get_images_list

sbonazzo at redhat.com sbonazzo at redhat.com
Wed Feb 24 07:26:35 UTC 2016


Sandro Bonazzola has submitted this change and it was merged.

Change subject: storage: fixing a double call of get_images_list
......................................................................


storage: fixing a double call of get_images_list

Using just
 result = cli.getImagesList(self._sdUUID)
instead of
 result = cli.getImagesList(cli.getImagesList(self._sdUUID))

It's iSCSI specific since getImagesList always fails on NFS
due to rhbz#1274622 but in that case scanning the directory
on the mount point is enough while on iSCSI we have to rely
just on getImagesList since before preparing the images we
don't have a link to the volumes.

Change-Id: I2baf5d24d794486b713fbafdea4049e0b885671f
Bug-Url: https://bugzilla.redhat.com/1297457
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M ovirt_hosted_engine_ha/lib/image.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Simone Tiraboschi: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53935
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2baf5d24d794486b713fbafdea4049e0b885671f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list