Change in ovirt-engine[ovirt-engine-3.6.2]: engine: Integrate NetworkAttachmentIpConfigurationValidator

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: engine: Integrate NetworkAttachmentIpConfigurationValidator
......................................................................


engine: Integrate NetworkAttachmentIpConfigurationValidator

Add ip configuration validation to HostSetupNetworksValidator.

After consulting where the vailidation should happened, it was
decided that the validation will occur only in the backend.
Please note, The
web application has a default ip configuration set for boot
protocol none and additional validaition to other boot
protocols.
Regarding the REST API cilent, the decision was different from
the web application as no validaiton nor default ip
configuration will be set.
It reasonable to ask a script writer to be responisable enought
to meet the demand for valid ip configuration.
It was also decided not to enforce a valid ip configuration via
api.xsd in order to keep it as general as possible.

Also, please note that only new network attachment should pass
the ip configuration validation as already exist attached
network has different
logic.  For example, a network with dhcp already configured will
have ip details.

Change-Id: I19b5f0f15f3fc494301928cfcb957bd09863c6c2
Bug-Url: https://bugzilla.redhat.com/1270807
Signed-off-by: Eliraz Levi <elevi at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
5 files changed, 116 insertions(+), 109 deletions(-)

Approvals:
  Tal Nisan: Passed CI tests
  Eliraz Levi: Verified
  Alona Kaplan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51238
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I19b5f0f15f3fc494301928cfcb957bd09863c6c2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Eliraz Levi <elevi at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>