Change in ovirt-engine[master]: core: CoCo - avoid using removeFromHirerchy on callback

derez at redhat.com derez at redhat.com
Thu Jan 7 11:51:14 UTC 2016


Daniel Erez has submitted this change and it was merged.

Change subject: core: CoCo - avoid using removeFromHirerchy on callback
......................................................................


core: CoCo - avoid using removeFromHirerchy on callback

Do not remove the command from hirerchy when it is ended so the
aggragator command can determine if the command succeeded or not.

Change-Id: Id60b300cda80fe2555f58f300ab83fad727be736
Bug-Url: https://bugzilla.redhat.com/1288852
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllCinderSnapshotDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllVmCinderDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderSnapshotCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java
6 files changed, 13 insertions(+), 8 deletions(-)

Approvals:
  Daniel Erez: Verified
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51367
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id60b300cda80fe2555f58f300ab83fad727be736
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list