Change in ovirt-engine[ovirt-engine-3.6]: userportal: Fix of FE NPE during too fast clicking at list r...

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: userportal: Fix of FE NPE during too fast clicking at list refresh
......................................................................


userportal: Fix of FE NPE during too fast clicking at list refresh

Too fast clicking at refresh button in Basic Userportal or Extended
Userportal > VMs could cause nearly concurrent run of callbacks in
UserPortal(Basic)ListModel#onVmAndPoolLoad() that resulted in getvms()
returning null and thus to NPE.

* Fields 'vms' and 'pools' transformed to local variables to prevent
  concurrent data manipulation.

* Methods 'onVmAndPoolLoad' and 'finishSearch' moved to parent class -
  removing code duplication.

Change-Id: I8d5bb5587c09cfb8981e51a6cb3202c4f0a9d174
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1296458
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
3 files changed, 121 insertions(+), 243 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51496
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d5bb5587c09cfb8981e51a6cb3202c4f0a9d174
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>