Change in ovirt-engine[ovirt-engine-3.6.2]: core: show snapshot name properly after live merge of snapsh...

tnisan at redhat.com tnisan at redhat.com
Thu Jan 7 15:41:15 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: show snapshot name properly after live merge of snapshot disk
......................................................................


core: show snapshot name properly after live merge of snapshot disk

After Live Merge of a snapshot disk (Storage > Disk Snapshots > Remove),
the audit log shows the snapshot name of '<UNKNOWN>'.  The problem is
that the image record is used to look up the name, and this is not
available after the merge operation is done.

Instead, cache the snapshot name in the parameters and refer to this
after the merge operation is complete.

Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8
Bug-Url: https://bugzilla.redhat.com/1204609
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskSnapshotsParameters.java
2 files changed, 19 insertions(+), 6 deletions(-)

Approvals:
  Greg Padgett: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list