Change in ovirt-engine[ovirt-engine-3.6.2]: core: Filter out child Cinder commands on end action.

tnisan at redhat.com tnisan at redhat.com
Sun Jan 10 11:42:21 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Filter out child Cinder commands on end action.
......................................................................


core: Filter out child Cinder commands on end action.

EndAction was being called only for image commands.
Cinder commands should get filtered out on endAction since the logic
is already being done as part of the Cinder command endAction.

In the future this filtering should be removed and the child endAction
should be called abstractically for Cinder and Image volumes.

Change-Id: Ia8e5119ec55f498b4a688334cd6302abe7287388
Bug-Url: https://bugzilla.redhat.com/1288852
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
2 files changed, 16 insertions(+), 14 deletions(-)

Approvals:
  Tal Nisan: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/51589
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8e5119ec55f498b4a688334cd6302abe7287388
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list