Change in ovirt-engine-cli[cli_3.6]: cli: Improve the "no console found" messages

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Jan 11 14:42:24 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: cli: Improve the "no console found" messages
......................................................................


cli: Improve the "no console found" messages

Currently the messages used to indicate that no console viewer was found
are the same for VNC and SPICE, and they are't very friendly as they
don't provide a hint about the binary that needs to be installed. This
patch improves the messages so that they include a hint about the binary
that needs to be installed.

When the graphics protocol is SPICE the error message will be the
following:

  a SPICE viewer was not found, please install a SPICE viewer (e.g.
  remote-viewer) first.

When the graphics protocol is VNC the error message will be the
following:

  a VNC viewer was not found, please install a VNC viewer (e.g.
  remote-viewer, or vncviewer) first.

Change-Id: I9952a2576a8544be712123e8ce0b6b92babacda0
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=807696#c13
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 33468a8674937c91dd8bd90e7bb43a77cd193220)
---
M src/cli/messages.py
M src/ovirtcli/platform/posix/spice.py
M src/ovirtcli/platform/posix/vnc.py
3 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51643
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9952a2576a8544be712123e8ce0b6b92babacda0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list