Change in ovirt-engine[master]: core: Fix SyntaxCheckerTest asserts

amureini at redhat.com amureini at redhat.com
Wed Jan 13 21:12:38 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fix SyntaxCheckerTest asserts
......................................................................


core: Fix SyntaxCheckerTest asserts

Fixed asserts to use equality instead of identity (==, !=). While the
JVM usually produces the same literal from the pool this is not a
behavior that should be relied on. Instead, logical equality should be
checked.

Change-Id: I36e9106ae39b4fc0ef0ba315c0a65de04a0267b4
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/51258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36e9106ae39b4fc0ef0ba315c0a65de04a0267b4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list