Change in ovirt-engine-sdk-ruby[master]: Use "List" instead of "Array"

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Jan 18 09:52:17 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Use "List" instead of "Array"
......................................................................


Use "List" instead of "Array"

Currently when a list of objects is received from the server it is
converted to an instance of the Ruby "Array" class. This patch
introduces a new "List" class, that extends the Ruby "Array" class,
currently with no methods. List of objects returned from the SDK will be
of this type. Later patches will take advantage of this "List" class,
for example to add methods to support following links.

The patch also renames the base "Type" class to "Struct", as that better
reflects the difference between struct and list types.

Change-Id: I1cbcd1eab8bd8b95d7d4a0e0537ccd8a47e81f64
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/RubyNames.java
M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java
C sdk/lib/ovirt/sdk/v4/types/list.rb
R sdk/lib/ovirt/sdk/v4/types/struct.rb
M sdk/spec/vm_reader_spec.rb
A sdk/spec/vm_spec.rb
7 files changed, 79 insertions(+), 33 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51913
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1cbcd1eab8bd8b95d7d4a0e0537ccd8a47e81f64
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list