Change in ovirt-engine[master]: engine: Fix NPE in Glance import image as template

tnisan at redhat.com tnisan at redhat.com
Mon Jan 18 12:19:17 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: engine: Fix NPE in Glance import image as template
......................................................................


engine: Fix NPE in Glance import image as template

In AddVmTemplateCommand, the vm variable is not available in the
flow of importing image as template from Glance. Using it will
cause a NullPointerException.

Instead of using the vm for getting the compatibility version, we use
the master VM from the parameters or the cluster.

Change-Id: I066e33fc1414675799fe3ffb655bfe4204e1ba3d
Bug-Url: https://bugzilla.redhat.com/1299233
Signed-off-by: Fred Rolland <frolland at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Freddy Rolland: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I066e33fc1414675799fe3ffb655bfe4204e1ba3d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list