Change in ovirt-engine-sdk-ruby[master]: Add "_service" to all locator methods

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Jan 20 11:02:29 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Add "_service" to all locator methods
......................................................................


Add "_service" to all locator methods

Currently the locator methods are named like in the specification of the
API. For example, the method used to find the virtual machines service
is named "vms". This patch changes those methods so that they will have
a "_service" suffix, making it clearer that they return references to
services, not objects.

Change-Id: If3dacbd895fda86b9672643bb045fd23cf2203a0
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M sdk/examples/add_cluster.rb
M sdk/examples/add_data_center.rb
M sdk/examples/add_host.rb
M sdk/examples/add_nfs_data_storage_domain.rb
M sdk/examples/add_nfs_iso_storage_domain.rb
M sdk/examples/add_vm.rb
M sdk/examples/add_vm_disk.rb
M sdk/examples/add_vm_nic.rb
M sdk/examples/attach_nfs_data_storage_domain.rb
M sdk/examples/attach_nfs_iso_storage_domain.rb
M sdk/examples/follow_vm_links.rb
M sdk/examples/list_vms.rb
M sdk/examples/remove_host.rb
M sdk/examples/remove_vm.rb
M sdk/examples/search_vms.rb
M sdk/examples/start_vm.rb
M sdk/examples/stop_vm.rb
M sdk/examples/update_data_center.rb
M sdk/lib/ovirt/sdk/v4/connection.rb
M sdk/spec/clusters_service_spec.rb
M sdk/spec/data_centers_service_spec.rb
M sdk/spec/storage_domains_service_spec.rb
M sdk/spec/vms_service_spec.rb
24 files changed, 68 insertions(+), 68 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/52485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If3dacbd895fda86b9672643bb045fd23cf2203a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list