Change in ovirt-engine[ovirt-engine-3.6]: frontend: Fix name uniqueness chack in ImportVmModel

tnisan at redhat.com tnisan at redhat.com
Tue Jan 26 16:10:10 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: frontend: Fix name uniqueness chack in ImportVmModel
......................................................................


frontend: Fix name uniqueness chack in ImportVmModel

Now when checking the name uniqueness of imported VM, we check for conflict
only VMs in target data center.

To facilitate this the data center loading part from
ImportVmFromExportDomainModel#doInit() and
ImportVmFromExternalProviderModel#doInit() had to be extracted into special
helpers withDataCenterLoaded() that are used to wrap the setItems() method doing
the name uniqueness analysis - since it requires access to storagePool.id.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912263
Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
4 files changed, 102 insertions(+), 79 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Martin Betak: Verified



-- 
To view, visit https://gerrit.ovirt.org/52706
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list