Change in ovirt-engine[master]: core: Separate VmDevicesMonitoring from VmsMonitoring

ahadas at redhat.com ahadas at redhat.com
Tue Jan 26 16:19:48 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: Separate VmDevicesMonitoring from VmsMonitoring
......................................................................


core: Separate VmDevicesMonitoring from VmsMonitoring

Move all processing related to VM device changes into a separate
singleton class named VmDevicesMonitoring. It supports processing of two
types of changes:

1. VM status events, when device information hash returned by VDSM is
compared to the previous one. FullList VDSM command is used then to get
information about all devices. Processing result of FullList that was
run somewhere else is also supported.
2. Individual changes in devices. This mechanism may be used in the
future to process 'device changed' events from VDSM.

The current device information hash is kept inside VmDevicesMonitoring
and stored in the DB only to restore it after Engine restart.

Change-Id: I8726c74c155f447aee4a93912fb8606430abeb1b
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVmStatsRefresher.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmDevicesMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVmStatsRefresher.java
M packaging/dbscripts/vms_sp.sql
11 files changed, 710 insertions(+), 308 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, but someone else must approve
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8726c74c155f447aee4a93912fb8606430abeb1b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list