Change in ovirt-engine[master]: core: Pass storage pool ID to disk images on storage validation

tnisan at redhat.com tnisan at redhat.com
Mon Jul 4 12:44:09 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Pass storage pool ID to disk images on storage validation
......................................................................


core: Pass storage pool ID to disk images on storage validation

Commit 2c6791 introduced a refactoring of whether images exist on storage
check, however it used the storage pool ID taken from the images where
in the case of import the image storage pool ID contains the original
storage pool the images resided on which may not be the storage pool we
import the image to.
The storage pool ID was restored from the original behavior and is now
taken from the parameters of the commands.

Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646
Signed-off-by: Tal Nisan <tnisan at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1352422
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java
3 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Verified; Passed CI tests
  Liron Aravot: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/60131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list