Change in ovirt-engine[ovirt-engine-4.0]: webadmin: fix UI exceptions in volumes tab

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: fix UI exceptions in volumes tab
......................................................................


webadmin: fix UI exceptions in volumes tab

This patch fixes the UI exceptions in following places

1. Exceptions are flooded in the UI, with user hower
over the the empty Activities column in Gluster Volumes
tab and Bricks Subtab.

 There is a NPE in VolumeActivityCompositeCell.
getContainerElement() method.  Fixed this issue by showing
 the composite cell always.  When there is not activity in
 the volume then we will add a table with empty row.

2. There is an exception in UI, when there is no suitable
cluster for gep rep slave. We should not try to set the
selection when the list itself is empty.

Change-Id: If1fcfb584dd250ec7550df98eeb4dfe7c442fc5a
Bug-Url: https://bugzilla.redhat.com/1303878
Signed-off-by: Ramesh Nachimuthu <rnachimu at redhat.com>
(cherry picked from commit dde3b1190ac518980e9ec12815899da5e845f65f)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivityCompositeCell.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivitySeperatorCell.java
5 files changed, 24 insertions(+), 29 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Sahina Bose: Looks good to me, approved
  Ramesh N: Verified



-- 
To view, visit https://gerrit.ovirt.org/60085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1fcfb584dd250ec7550df98eeb4dfe7c442fc5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>