Change in ovirt-engine[master]: core: refactor VmInternalData

ahadas at redhat.com ahadas at redhat.com
Wed Jul 6 13:56:27 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: refactor VmInternalData
......................................................................


core: refactor VmInternalData

Replace all constructors with one constructor that receives the notification
time. All other arguments should be set with setter methods. This simplifies
the instanciation of this class.

In addition, statically import the methods in VdsBrokerObjectsBuilder that
are used in VmStatsVdsBrokerCommand and in ListVDSCommand in order to make
it more readable.

Change-Id: Iceeacc97412fdba7bb54d1d1c4139d800a45528a
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java
5 files changed, 49 insertions(+), 51 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/60225
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iceeacc97412fdba7bb54d1d1c4139d800a45528a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list