Change in ovirt-engine[master]: core: Change VmDevice plugged property to a primitive boolean

tnisan at redhat.com tnisan at redhat.com
Thu Jul 7 12:11:39 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Change VmDevice plugged property to a primitive boolean
......................................................................


core: Change VmDevice plugged property to a primitive boolean

Since VmDevice.getIsPlugged always returns a value of true/false we can
change all legacy null values in the DB to false and return them as is
without the redundant check.

Change-Id: I53064843f448d4ef75baed0d5811e207080257fc
Bug-Url: https://bugzilla.redhat.com/1352966
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
A 04_01_0130_change_vm_device_null_plugged_values_to_false.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusColumn.java
4 files changed, 15 insertions(+), 12 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53064843f448d4ef75baed0d5811e207080257fc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list