Change in ovirt-engine[master]: core: Rename storageTypeComparator to be more specific.

mlipchuk at redhat.com mlipchuk at redhat.com
Mon Jul 11 15:04:01 UTC 2016


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Rename storageTypeComparator to be more specific.
......................................................................


core: Rename storageTypeComparator to be more specific.

StorageTypeComperator simply compare between file
and block storage domain.
File type is a more complex type than only file or block therefore
renaming the class to be more specific to StorageTypeFileComparator.

Change-Id: I128362e6261962e453686b75e9804ea25a950ed5
Bug-Url: https://bugzilla.redhat.com/1353137
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeFileComparator.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeFileComparatorTest.java
3 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/60298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I128362e6261962e453686b75e9804ea25a950ed5
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list