Change in ovirt-engine[master]: core: CommandsCallbackPoller - EXECUTION_FAILED handling

laravot at redhat.com laravot at redhat.com
Tue Jul 12 09:19:41 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: CommandsCallbackPoller - EXECUTION_FAILED handling
......................................................................


core: CommandsCallbackPoller - EXECUTION_FAILED handling

The initCommandExecutor() method updates command whose exuection wasn't
completed to EXECUTION_FAILED status.
Command status might be changed on ENDED_WITH_FAILURE even if it wasn't
executed yet to indicate failure (for example, when the command fails
on the validate() phase), those commands status shouldn't be changed
to EXECUTION_FAILED status which is handled by the infrastacture.

Change-Id: Ic3eaef060d4e8c148a20c967968838d9101fd45c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353604
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Ravi Nori: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved
  Liron Aravot: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/60345
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3eaef060d4e8c148a20c967968838d9101fd45c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list