Change in ovirt-engine[master]: core: CommandBase - don't update the command entity always

laravot at redhat.com laravot at redhat.com
Tue Jul 12 12:49:55 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: CommandBase - don't update the command entity always
......................................................................


core: CommandBase - don't update the command entity always

In change Iae96c executeAction() was changed to only update the command
entity if present after the execution.
On flows with async tasks a CommandEntity is being created
for the root command with special values during the execution,
the update done in CommandBase will override those values to different ones.

This patch sets the update to be done only on commands with cb/parent command
with cb to avoid updating the unneeded entities.

Change-Id: I68af8d469ce9f42c8b1230fc4bef23448345b59a
Bug-Url: https://bugzilla.redhat.com/1352825
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Moti Asayag: Looks good to me, approved
  Liron Aravot: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/60587
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68af8d469ce9f42c8b1230fc4bef23448345b59a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list