Change in ovirt-engine[master]: core: removed code duplicates.

masayag at redhat.com masayag at redhat.com
Wed Jul 13 04:55:52 UTC 2016


Moti Asayag has submitted this change and it was merged.

Change subject: core: removed code duplicates.
......................................................................


core: removed code duplicates.

The usecase is separate values by commas, no one currently needs to
separate by anything else, so to start with, there should be a method
handling the default usecase without the need of passing the separator
parameter.

Change-Id: I99354c58d7ddf8477e04bbbd6487a1abce2525b4
Signed-off-by: Martin Mucha <mmucha at redhat.com>
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachTemplatesToTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserGroupToTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachVdsToTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachVmsToTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachTemplateFromTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserGroupFromTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachVdsFromTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachVmFromTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
16 files changed, 47 insertions(+), 22 deletions(-)

Approvals:
  Martin Mucha: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved
  Yevgeny Zaspitsky: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/58621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99354c58d7ddf8477e04bbbd6487a1abce2525b4
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list